fix: allowing empty log group prefixes #87
Merged
+62
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryyakobe
force-pushed
the
ryyakobe/fixing_prefix
branch
from
3373d0b
to
0810ea1
Compare
ddneilson
approved these changes
Aug 27, 2020
yashda
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some RFDK constructs we allow setting a custom log group prefix.
If no prefix is given, then we use a default prefix. This is done with the trenary operator
?::const prefix = props.logGroupProps?.logGroupPrefix ? props.logGroupProps.logGroupPrefix : SOME_DEFAULT_PREFIX;So if the prefix is empty
logGroupPrefix = '', we will still use the default prefix, instead of using no prefix at all. This PR fixes this issue by replacing the trenary operator?:with??:const prefix = props.logGroupProps?.logGroupPrefix ?? SOME_DEFAULT_PREFIX;Also, updated the unit-tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license